Give Phame blogs mutable interact policies
ClosedPublic
Actions

Authored by epriestley on Apr 1 2022, 7:05 PM.

Details

Reviewers: None
Maniphest Tasks: T13661: Give Phame configurable interact policies
Commits: rPc25595417f8a: Give Phame blogs mutable interact policies

Summary

I'm fairly sure these policies don't actually do anything (you can't "interact" with a blog) but the primarily support a Phame Post object policy of "Same as Parent Blog", which is the "natural" interact policy for a post.

Most of this is infrastructure support for mutable interact policies: today, only Maniphest has interact mutability and only via indirect effects (locking tasks), not through a directly mutable "Can Interact" policy.

Test Plan

Ran storage upgrade, edited interact policy of a blog, saw appropriate persistence and transactions.

Created and edited a task to make sure there's no weird fallout from increasing what can be done with interact policies.

Diff Detail

Repository

rP Phabricator

Branch

phameint4

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25634
Build 35462: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	6 ms	PhabricatorPolicyDataTestCase::testProjectPolicyMembership EXCEPTION (RuntimeException): strlen(): Passing null to parameter #1 ($string) of type string is deprecated #0 /Users/epriestley/dev/core/lib/phabricator/src/applications/project/storage/PhabricatorProject.php(410): PhutilErrorHandler::handleError(8192, 'strlen(): Passi...', '/Users/epriestl...', 410) #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/policy/__tests__/PhabricatorPolicyDataTestCase.php(16): PhabricatorProject->save()
	212 ms	PhabricatorCelerityTestCase::testCelerityMaps 3 assertions passed.
	11 ms	PhabricatorConduitTestCase::testConduitMethods 1 assertion passed.
	0 ms	PhabricatorInfrastructureTestCase::testApplicationsInstalled 1 assertion passed.
	1 ms	PhabricatorInfrastructureTestCase::testRejectMySQLNonUTF8Queries 1 assertion passed.
		View Full Test Results (1 Failed · 29 Passed)