Page MenuHomePhabricator

Provide an API for parsing swap information from "/proc/meminfo"
ClosedPublic

Authored by epriestley on Nov 22 2021, 1:30 PM.
Tags
None
Referenced Files
F13277256: D21733.id51792.diff
Fri, May 31, 9:56 AM
F13275419: D21733.diff
Fri, May 31, 4:45 AM
F13272475: D21733.diff
Thu, May 30, 2:23 PM
F13270153: D21733.diff
Wed, May 29, 9:08 AM
F13261524: D21733.diff
Mon, May 27, 1:08 AM
F13245366: D21733.diff
Thu, May 23, 5:58 AM
F13239047: D21733.id51792.diff
Tue, May 21, 11:43 PM
F13238979: D21733.id51793.diff
Tue, May 21, 11:09 PM
Subscribers
None

Diff Detail

Repository
rARC Arcanist
Branch
mem1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25586
Build 35393: Run Core Tests
Build 35392: arc lint + arc unit

Event Timeline

Satisfy lint by catching and re-throwing Throwable.

It would be slightly more appropriate for this class to throw a more tailored exception, but I don't think there's a suitable existing exception and this already feels very heavy for its actual use case.

This overlaps somewhat with PhutilSystem::getSystemMemoryInformation(), but that mechanism is narrower and also doesn't really work in practice, so it would probably be reasonable to remove it entirely.