Page MenuHomePhabricator

Provide an API for parsing swap information from "/proc/meminfo"
ClosedPublic

Authored by epriestley on Nov 22 2021, 1:30 PM.
Tags
None
Referenced Files
F15395339: D21733.id51793.diff
Sun, Mar 16, 5:57 AM
F15392352: D21733.diff
Sat, Mar 15, 2:43 PM
F15391287: D21733.id51793.diff
Sat, Mar 15, 9:13 AM
F15388854: D21733.id51791.diff
Sat, Mar 15, 4:32 AM
F15388033: D21733.id51792.diff
Sat, Mar 15, 3:13 AM
F15387892: D21733.id51793.diff
Sat, Mar 15, 3:04 AM
F15372240: D21733.diff
Wed, Mar 12, 1:27 PM
F15346027: D21733.id51793.diff
Mon, Mar 10, 1:41 PM
Subscribers
None

Diff Detail

Repository
rARC Arcanist
Branch
mem1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/filesystem/memory/__tests__/ArcanistHostMemorySnapshotTestCase.php:28XHP132Partial Catch
Unit
Tests Passed
Build Status
Buildable 25585
Build 35391: Run Core Tests
Build 35390: arc lint + arc unit

Event Timeline

Satisfy lint by catching and re-throwing Throwable.

It would be slightly more appropriate for this class to throw a more tailored exception, but I don't think there's a suitable existing exception and this already feels very heavy for its actual use case.

This overlaps somewhat with PhutilSystem::getSystemMemoryInformation(), but that mechanism is narrower and also doesn't really work in practice, so it would probably be reasonable to remove it entirely.