Page MenuHomePhabricator

Provide an API for parsing swap information from "/proc/meminfo"
ClosedPublic

Authored by epriestley on Nov 22 2021, 1:30 PM.
Tags
None
Referenced Files
F12835961: D21733.id.diff
Thu, Mar 28, 3:30 PM
Unknown Object (File)
Wed, Mar 27, 12:33 PM
Unknown Object (File)
Sun, Mar 10, 8:14 AM
Unknown Object (File)
Feb 12 2024, 1:06 AM
Unknown Object (File)
Feb 4 2024, 1:42 AM
Unknown Object (File)
Feb 4 2024, 1:27 AM
Unknown Object (File)
Jan 18 2024, 7:57 AM
Unknown Object (File)
Jan 18 2024, 7:56 AM
Subscribers
None

Diff Detail

Repository
rARC Arcanist
Branch
mem1
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/filesystem/memory/__tests__/ArcanistHostMemorySnapshotTestCase.php:28XHP132Partial Catch
Unit
Tests Passed
Build Status
Buildable 25585
Build 35391: Run Core Tests
Build 35390: arc lint + arc unit

Event Timeline

Satisfy lint by catching and re-throwing Throwable.

It would be slightly more appropriate for this class to throw a more tailored exception, but I don't think there's a suitable existing exception and this already feels very heavy for its actual use case.

This overlaps somewhat with PhutilSystem::getSystemMemoryInformation(), but that mechanism is narrower and also doesn't really work in practice, so it would probably be reasonable to remove it entirely.