Page MenuHomePhabricator
Differential D21695

Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 4:43 PM.
Tags
None
Referenced Files
F18439332: D21695.id51709.diff
Sun, Aug 31, 2:21 PM
F18411733: D21695.id51658.diff
Sat, Aug 30, 6:03 AM
F18304883: D21695.id.diff
Sat, Aug 23, 11:06 PM
F18106572: D21695.diff
Sun, Aug 10, 11:09 PM
F18084288: D21695.id.diff
Tue, Aug 5, 2:39 PM
F18078740: D21695.diff
Mon, Aug 4, 8:22 PM
F17953818: D21695.id.diff
Aug 1 2025, 3:30 AM
F17938643: D21695.diff
Jul 31 2025, 2:28 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods
Summary

Ref T13072. These don't do anything useful yet, but get the skeletons in.

Test Plan

Loaded documentation pages without fataling.

Diff Detail

Repository
rP Phabricator
Branch
build12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25461
Build 35190: Run Core Tests
Build 35189: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 16 2021, 4:43 PM
Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 4:43 PM
Harbormaster completed remote builds in B25461: Diff 51658.Jul 16 2021, 4:44 PM
epriestley requested review of this revision.Jul 16 2021, 4:44 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
Closed by commit rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2ff1d4b3b007: Add stub "harbormaster.build.edit" and "harbormaster.buildable.edit" API methods.

Revision Contents
Changeset List

Diff 51658

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterBuildEditAPIMethod.php

Loading...
View Options

src/applications/harbormaster/conduit/HarbormasterBuildableEditAPIMethod.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildEditEngine.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildableEditEngine.php

Loading...
Phabricator · Built by Phacility