Page MenuHomePhabricator
Differential D21694

Modularize "HarbormasterBuildableTransaction"
ClosedPublic
Actions

Authored by epriestley on Jul 16 2021, 4:00 PM.
Tags
None
Referenced Files
F20055627: D21694.id51707.diff
Sun, May 31, 12:28 PM
F20054780: D21694.id51657.diff
Sun, May 31, 11:42 AM
Unknown Object (File)
Apr 1 2026, 11:19 AM
Unknown Object (File)
Mar 6 2026, 1:44 PM
Unknown Object (File)
Mar 6 2026, 1:44 PM
Unknown Object (File)
Mar 4 2026, 6:37 PM
Unknown Object (File)
Feb 27 2026, 8:28 PM
Unknown Object (File)
Feb 13 2026, 3:23 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits
rP346ffc51e100: Modularize "HarbormasterBuildableTransaction"
Summary

Ref T13072. Trivially convert this into a modular transaction type.

Test Plan

Issued commands to a buildable.

Diff Detail

Repository
rP Phabricator
Branch
build11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25460
Build 35188: Run Core Tests
Build 35187: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 16 2021, 4:00 PM
Owners added a subscriber: Restricted Owners Package.Jul 16 2021, 4:00 PM
Harbormaster completed remote builds in B25460: Diff 51657.Jul 16 2021, 4:01 PM
epriestley requested review of this revision.Jul 16 2021, 4:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:18 PM
Closed by commit rP346ffc51e100: Modularize "HarbormasterBuildableTransaction" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP346ffc51e100: Modularize "HarbormasterBuildableTransaction".

Revision Contents
Changeset List

Diff 51657

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableActionController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildableTransactionEditor.php

Loading...
View Options

src/applications/harbormaster/storage/HarbormasterBuildableTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableMessageTransaction.php

Loading...
View Options

src/applications/harbormaster/xaction/buildable/HarbormasterBuildableTransactionType.php

Loading...
Phabricator · Built by Phacility