Differential D21688

Remove "HarbormasterBuildTransaction::TYPE_CREATE"
ClosedPublic
Actions

Authored by epriestley on Jul 15 2021, 6:08 PM.

Details

Reviewers: None
Maniphest Tasks: T13072: Merge Harbormaster BuildCommand into BuildMessage
Commits: rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE"

Summary

Ref T13072. No callers currently generate these transactions, and they probably never have. Remove them.

Test Plan

Grepped for "HarbormasterBuildTransaction::TYPE_CREATE" and "self::TYPE_CREATE" in the class, found no hits.

Diff Detail

Repository

rP Phabricator

Branch

build5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25453
Build 35174: Run Core Tests
Build 35173: arc lint + arc unit

Event Timeline

epriestley created this revision.Jul 15 2021, 6:08 PM

Owners added a subscriber: Restricted Owners Package.Jul 15 2021, 6:08 PM

Harbormaster completed remote builds in B25453: Diff 51650.Jul 15 2021, 6:10 PM

epriestley requested review of this revision.Jul 15 2021, 6:10 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2021, 9:17 PM

Closed by commit rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPb84c02959a8b: Remove "HarbormasterBuildTransaction::TYPE_CREATE".

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

editor/

HarbormasterBuildTransactionEditor.php

7 lines

storage/

HarbormasterBuildTransaction.php

9 lines

Diff 51650

View Options

src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php