Page MenuHomePhabricator
Differential D21681

Update templates used with mercurial to remove '--debug'
ClosedPublic
Actions

Authored by cspeckmim on Jul 7 2021, 11:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 4, 10:04 PM
Unknown Object (File)
Wed, Dec 25, 10:51 AM
Unknown Object (File)
Wed, Dec 25, 2:54 AM
Unknown Object (File)
Tue, Dec 24, 3:23 AM
Unknown Object (File)
Sun, Dec 15, 9:25 AM
Unknown Object (File)
Fri, Dec 13, 9:38 PM
Unknown Object (File)
Fri, Dec 13, 3:30 PM
Unknown Object (File)
Thu, Dec 12, 11:44 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC514c12366b63: Update templates used with mercurial to remove '--debug'
Summary

Refs D21679 (phabricator changes)

This updates Arcanist to be able to check whether the version of Mercurial supports using {p1.node} template format vs. {p1node}.

Test Plan

Tested under coverage from D21679

Diff Detail

Repository
rARC Arcanist
Branch
newtemplates
Lint
Lint Passed
Unit
Tests Skipped
Build Status
Buildable 25413
Build 35099: Run Core Tests
Build 35098: arc lint + arc unit

Event Timeline

cspeckmim created this revision.Jul 7 2021, 11:54 PM
cspeckmim held this revision as a draft.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJul 7 2021, 11:54 PM
Herald added a subscriber: epriestley. · View Herald Transcript
Harbormaster completed remote builds in B25413: Diff 51610.Jul 7 2021, 11:54 PM
cspeckmim mentioned this in D21679: Update templates used with mercurial to remove '--debug'.Jul 7 2021, 11:54 PM
cspeckmim edited the summary of this revision. (Show Details)
cspeckmim updated this revision to Diff 51612.Jul 8 2021, 2:48 AM

Whoops, fix erroneous self::version_compare() to just version_compare()

Harbormaster completed remote builds in B25415: Diff 51612.Jul 8 2021, 2:49 AM
cspeckmim published this revision for review.Jul 8 2021, 3:55 AM
cspeckmim edited the test plan for this revision. (Show Details)
cspeckmim added inline comments.
src/filesystem/binary/PhutilMercurialBinaryAnalyzer.php
68

versino

5-o-clock-somewhere.png (281×418 px, 149 KB)

cspeckmim updated this revision to Diff 51615.Jul 8 2021, 3:58 AM

"fix" "typos"

Harbormaster completed remote builds in B25418: Diff 51615.Jul 8 2021, 3:59 AM
epriestley accepted this revision.Jul 8 2021, 5:46 PM
This revision is now accepted and ready to land.Jul 8 2021, 5:46 PM
Herald added a subscriber: Korvin. · View Herald TranscriptJul 8 2021, 5:46 PM
cspeckmim updated this revision to Diff 51617.Jul 9 2021, 1:01 AM

Adding a capability check for hg annotate --template

Harbormaster completed remote builds in B25420: Diff 51617.Jul 9 2021, 1:01 AM
epriestley added a comment.Jul 9 2021, 1:19 AM

😎

Closed by commit rARC514c12366b63: Update templates used with mercurial to remove '--debug' (authored by cspeckmim). · Explain WhyJul 9 2021, 4:35 PM
This revision was automatically updated to reflect the committed changes.
cspeckmim added a commit: rARC514c12366b63: Update templates used with mercurial to remove '--debug'.
cspeckmim mentioned this in rPe5de7f08436d: Update templates used with mercurial to remove '--debug'.

Revision Contents
Changeset List

PathSize
src/
filesystem/
binary/
16 lines

Diff 51610

View Options

src/filesystem/binary/PhutilMercurialBinaryAnalyzer.php

Loading...
Phabricator · Built by Phacility