Differential D21674

Add an "Authority" control to Packages to support "Watcher" packages
ClosedPublic
Actions

Authored by epriestley on Jun 25 2021, 4:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 23, 2:53 AM

	Unknown Object (File)
	Sat, Nov 9, 4:37 PM

	Unknown Object (File)
	Mon, Oct 28, 1:59 PM

	Unknown Object (File)
	Oct 24 2024, 5:27 PM

	Unknown Object (File)
	Oct 19 2024, 3:11 PM

	Unknown Object (File)
	Oct 18 2024, 1:20 PM

	Unknown Object (File)
	Oct 18 2024, 10:45 AM

	Unknown Object (File)
	Oct 17 2024, 4:38 AM

Subscribers

Restricted Owners Package

Details

Reviewers: None
Commits: rPa641ec82a323: Add an "Authority" control to Packages to support "Watcher" packages

Summary

See T13657. An install has "watcher" packages which should not allow owners to "Force Accept" other packages.

Test Plan

Created package A, which I own, on "/", with "Weak" authority.
Created package B, which I do not own, on "/src".
Created a revision which touches "/src" and added package B as a reviewer.
Attempted to accept the revision...
- Before patch: permitted to "Force Accept" for package B.
- After patch: not allowed to "Force Accept" for package B.
Verified that setting package "A" back to "Strong" authority allows a force-accept for package B.

Diff Detail

Repository

Branch

package1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25386
Build 35051: Run Core Tests
Build 35050: arc lint + arc unit

Event Timeline

epriestley created this revision.Jun 25 2021, 4:30 PM

Owners added a subscriber: Restricted Owners Package.Jun 25 2021, 4:30 PM

Harbormaster completed remote builds in B25385: Diff 51580.Jun 25 2021, 4:31 PM

epriestley requested review of this revision.Jun 25 2021, 4:31 PM

Allow "owners.search" API to read this setting.

Screen Shot 2021-06-25 at 9.59.08 AM.png (239×500 px, 27 KB)

Harbormaster completed remote builds in B25386: Diff 51581.Jun 25 2021, 5:01 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2021, 8:48 PM

Closed by commit rPa641ec82a323: Add an "Authority" control to Packages to support "Watcher" packages (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa641ec82a323: Add an "Authority" control to Packages to support "Watcher" packages.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20210625.owners.01.authority.sql

2 lines

20210625.owners.02.authority-default.sql

3 lines

src/

__phutil_library_map__.php

applications/

differential/

storage/

DifferentialRevision.php

8 lines

owners/

controller/

PhabricatorOwnersDetailController.php

6 lines

editor/

PhabricatorOwnersPackageEditEngine.php

13 lines

query/

PhabricatorOwnersPackageQuery.php

13 lines

storage/

PhabricatorOwnersPackage.php

45 lines

xaction/

PhabricatorOwnersPackageAuthorityTransaction.php

56 lines

Diff 51581

resources/sql/autopatches/20210625.owners.01.authority.sql

Loading...

resources/sql/autopatches/20210625.owners.02.authority-default.sql

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...

src/applications/owners/xaction/PhabricatorOwnersPackageAuthorityTransaction.php

Loading...