Page MenuHomePhabricator

Add an "Authority" control to Packages to support "Watcher" packages

Authored by epriestley on Jun 25 2021, 4:30 PM.



See T13657. An install has "watcher" packages which should not allow owners to "Force Accept" other packages.

Test Plan
  • Created package A, which I own, on "/", with "Weak" authority.
  • Created package B, which I do not own, on "/src".
  • Created a revision which touches "/src" and added package B as a reviewer.
  • Attempted to accept the revision...
    • Before patch: permitted to "Force Accept" for package B.
    • After patch: not allowed to "Force Accept" for package B.
  • Verified that setting package "A" back to "Strong" authority allows a force-accept for package B.

Diff Detail

rP Phabricator
Lint Passed
Tests Passed
Build Status
Buildable 25386
Build 35051: Run Core Tests
Build 35050: arc lint + arc unit

Event Timeline

Owners added a subscriber: Restricted Owners Package.Jun 25 2021, 4:30 PM
  • Allow "" API to read this setting.

Screen Shot 2021-06-25 at 9.59.08 AM.png (239×500 px, 27 KB)

This revision was not accepted when it landed; it landed in state Needs Review.Jun 25 2021, 8:48 PM
This revision was automatically updated to reflect the committed changes.