Page MenuHomePhabricator

Avoid leaving stdin in nonblocking mode after a modern prompt
ClosedPublic

Authored by epriestley on May 30 2021, 8:31 AM.
Tags
None
Referenced Files
F13161488: D21666.id51561.diff
Mon, May 6, 7:41 AM
Unknown Object (File)
Fri, May 3, 8:29 AM
Unknown Object (File)
Mon, Apr 29, 6:09 AM
Unknown Object (File)
Thu, Apr 25, 2:20 AM
Unknown Object (File)
Sat, Apr 20, 5:44 PM
Unknown Object (File)
Sun, Apr 7, 1:42 PM
Unknown Object (File)
Apr 6 2024, 4:55 PM
Unknown Object (File)
Feb 20 2024, 9:34 PM
Subscribers
None

Details

Summary

Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan

This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Diff Detail

Repository
rARC Arcanist
Branch
prompt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25368
Build 35025: Run Core Tests
Build 35024: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2021, 8:31 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.