Page MenuHomePhabricator

Avoid leaving stdin in nonblocking mode after a modern prompt
ClosedPublic

Authored by epriestley on May 30 2021, 8:31 AM.
Tags
None
Referenced Files
F18268825: D21666.diff
Fri, Aug 22, 2:16 PM
F18250554: D21666.diff
Thu, Aug 21, 4:27 PM
F18205896: D21666.diff
Mon, Aug 18, 3:13 PM
F18106522: D21666.id.diff
Sun, Aug 10, 11:07 PM
F17852303: D21666.id.diff
Sun, Jul 27, 12:26 PM
F17839854: D21666.diff
Sat, Jul 26, 8:31 PM
F17839210: D21666.diff
Sat, Jul 26, 7:43 PM
F17643206: D21666.id51561.diff
Jul 11 2025, 9:16 PM
Subscribers
None

Details

Summary

Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan

This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Diff Detail

Repository
rARC Arcanist
Branch
prompt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25368
Build 35025: Run Core Tests
Build 35024: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2021, 8:31 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.