Page MenuHomePhabricator

Avoid leaving stdin in nonblocking mode after a modern prompt
ClosedPublic

Authored by epriestley on May 30 2021, 8:31 AM.
Tags
None
Referenced Files
F14080225: D21666.id51561.diff
Fri, Nov 22, 12:12 PM
F14075692: D21666.diff
Thu, Nov 21, 12:51 PM
Unknown Object (File)
Tue, Nov 19, 1:51 AM
Unknown Object (File)
Thu, Oct 31, 5:31 AM
Unknown Object (File)
Sat, Oct 26, 4:29 PM
Unknown Object (File)
Sat, Oct 26, 9:15 AM
Unknown Object (File)
Oct 10 2024, 4:34 PM
Unknown Object (File)
Oct 10 2024, 4:34 PM
Subscribers
None

Details

Summary

Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan

This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Diff Detail

Repository
rARC Arcanist
Branch
prompt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25368
Build 35025: Run Core Tests
Build 35024: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2021, 8:31 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.