Page MenuHomePhabricator

Avoid leaving stdin in nonblocking mode after a modern prompt
ClosedPublic

Authored by epriestley on May 30 2021, 8:31 AM.
Tags
None
Referenced Files
F15457080: D21666.diff
Sun, Mar 30, 2:14 PM
F15408282: D21666.diff
Tue, Mar 18, 10:11 PM
F15392615: D21666.diff
Sat, Mar 15, 4:22 PM
F15390177: D21666.diff
Sat, Mar 15, 5:58 AM
Unknown Object (File)
Feb 23 2025, 4:17 AM
Unknown Object (File)
Feb 22 2025, 8:28 PM
Unknown Object (File)
Feb 19 2025, 6:51 PM
Unknown Object (File)
Feb 19 2025, 6:51 PM
Subscribers
None

Details

Summary

Ref T13649. Currently, "arc" may leave stdin nonblocking after showing a prompt. This can cause various odd behaviors down the line.

I can't immediately reproduce this behavior on macOS in "zsh" or "bash" (I'm unable to get stdin to remain nonblocking beyond the process lifespan), and also don't have pcntl locally so there's a fair amount of handwaving here.

Test Plan

This is somewhat speculative since I can't immediately reproduce the behavior. I tested the locally-reachable paths (no pcntl) but they're not interesting.

Diff Detail

Repository
rARC Arcanist
Branch
prompt2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25368
Build 35025: Run Core Tests
Build 35024: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 30 2021, 8:31 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.