Correct issue with "bindings" conduit attachment
ClosedPublic
Actions

Authored by epriestley on Mar 27 2021, 4:25 PM.

Tags

None

Referenced Files

	F19395312: D21657.id51532.diff
	Sat, Dec 27, 9:26 AM

	F19361297: D21657.id51531.diff
	Fri, Dec 26, 9:57 AM

	F19302658: D21657.id.diff
	Tue, Dec 23, 3:51 PM

	F19120217: D21657.id.diff
	Dec 9 2025, 9:43 PM

	F19083448: D21657.id51532.diff
	Dec 2 2025, 12:36 PM

	F19076351: D21657.id51532.diff
	Dec 1 2025, 12:08 PM

	F18993628: D21657.id51531.diff
	Nov 19 2025, 8:13 AM

	F18978676: D21657.diff
	Nov 16 2025, 8:39 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13641: Support "Disabled" devices in Almanac
Commits: rP33c847e667b6: (stable) Correct issue with "bindings" conduit attachment
rP5b8b5f214148: Correct issue with "bindings" conduit attachment

Summary

Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan

Called method with each attachment, got good results instead of an exception.

Diff Detail

Repository

rP Phabricator

Branch

aserv1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25337
Build 34984: Run Core Tests
Build 34983: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 27 2021, 4:25 PM

Harbormaster completed remote builds in B25337: Diff 51531.Mar 27 2021, 4:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2021, 4:26 PM

epriestley requested review of this revision.

Closed by commit rP5b8b5f214148: Correct issue with "bindings" conduit attachment (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP5b8b5f214148: Correct issue with "bindings" conduit attachment.

epriestley added a commit: rP33c847e667b6: (stable) Correct issue with "bindings" conduit attachment.

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

engineextension/

AlmanacBindingsSearchEngineAttachment.php

4 lines

Diff 51531

View Options

src/applications/almanac/engineextension/AlmanacBindingsSearchEngineAttachment.php

Correct issue with "bindings" conduit attachmentClosedPublicActions