Page MenuHomePhabricator

Correct issue with "bindings" conduit attachment
ClosedPublic

Authored by epriestley on Mar 27 2021, 4:25 PM.
Tags
None
Referenced Files
F14396351: D21657.id51531.diff
Sun, Dec 22, 7:20 AM
F14396346: D21657.id51532.diff
Sun, Dec 22, 7:20 AM
Unknown Object (File)
Tue, Dec 17, 7:23 PM
Unknown Object (File)
Fri, Dec 6, 5:41 PM
Unknown Object (File)
Fri, Dec 6, 3:38 AM
Unknown Object (File)
Tue, Dec 3, 9:58 PM
Unknown Object (File)
Tue, Dec 3, 9:58 PM
Unknown Object (File)
Tue, Dec 3, 9:58 PM
Subscribers
None

Details

Summary

Ref T13641. These conditions are swapped, and "activeBindings" loads more data than necessary while "bindings" doesn't load enough.

Test Plan

Called method with each attachment, got good results instead of an exception.

Diff Detail

Repository
rP Phabricator
Branch
aserv1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25337
Build 34984: Run Core Tests
Build 34983: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 27 2021, 4:26 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.