Remove direct reads of form state from main Inline client code
ClosedPublic
Actions

Authored by epriestley on Mar 25 2021, 8:56 PM.

Tags

None

Referenced Files

	F15537612: D21647.diff
	Thu, Apr 24, 2:45 PM

	F15496910: D21647.diff
	Sun, Apr 13, 8:44 AM

	F15469421: D21647.id51516.diff
	Fri, Apr 4, 1:02 PM

	F15466881: D21647.id51537.diff
	Thu, Apr 3, 10:33 AM

	F15461235: D21647.id51516.diff
	Tue, Apr 1, 6:25 AM

	F15449074: D21647.id51537.diff
	Fri, Mar 28, 8:24 AM

	F15436684: D21647.id.diff
	Mar 25 2025, 3:51 PM

	F15432251: D21647.diff
	Mar 24 2025, 5:04 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13559: Include "Moved/Copied" gutter in 1-up diffs, and add aural cues, coverage, and fix inline counting
Commits: rP0f04d9e58458: Remove direct reads of form state from main Inline client code

Summary

Ref T13559. Instead of directly reading form state, make all callers use the "active" state instead. The state reads the form.

No functional changes, just clarifying responsiblites.

Test Plan

Created inlines, etc. See followup changes.

Diff Detail

Repository

rP Phabricator

Branch

istate4

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 25324
Build 34963: Run Core Tests
Build 34962: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 25 2021, 8:56 PM

Harbormaster completed remote builds in B25324: Diff 51516.Mar 25 2021, 8:57 PM

epriestley requested review of this revision.Mar 25 2021, 8:57 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM

Closed by commit rP0f04d9e58458: Remove direct reads of form state from main Inline client code (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP0f04d9e58458: Remove direct reads of form state from main Inline client code.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

webroot/

rsrc/

js/

application/

diff/

DiffInline.js

28 lines

Diff 51516

View Options

resources/celerity/map.php