Page MenuHomePhabricator

Remove direct reads of form state from main Inline client code
ClosedPublic

Authored by epriestley on Mar 25 2021, 8:56 PM.

Details

Summary

Ref T13559. Instead of directly reading form state, make all callers use the "active" state instead. The state reads the form.

No functional changes, just clarifying responsiblites.

Test Plan

Created inlines, etc. See followup changes.

Diff Detail

Repository
rP Phabricator
Branch
istate4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 25324
Build 34963: Run Core Tests
Build 34962: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2021, 4:00 PM
This revision was automatically updated to reflect the committed changes.