Page MenuHomePhabricator

Replace Differential "lint stars" with icons
ClosedPublic

Authored by epriestley on Mar 17 2021, 8:43 PM.
Tags
None
Referenced Files
F15396519: D21640.diff
Sun, Mar 16, 2:55 PM
F15385571: D21640.diff
Fri, Mar 14, 10:52 PM
F15376867: D21640.diff
Thu, Mar 13, 6:19 AM
F15345819: D21640.diff
Mon, Mar 10, 12:47 PM
F15285281: D21640.diff
Tue, Mar 4, 12:36 PM
Unknown Object (File)
Sun, Feb 23, 1:33 AM
Unknown Object (File)
Sat, Feb 22, 5:15 PM
Unknown Object (File)
Wed, Feb 19, 11:49 PM
Subscribers
None

Details

Summary

Ref T9764. These stars are inconsistent, not accessible, and generally weird. They predate icons.

Update them to use icons instead.

Test Plan

Screen Shot 2021-03-17 at 1.42.22 PM.png (381×177 px, 14 KB)

Screen Shot 2021-03-17 at 1.42.31 PM.png (332×302 px, 21 KB)

Screen Shot 2021-03-17 at 1.42.27 PM.png (75×316 px, 9 KB)

Diff Detail

Repository
rP Phabricator
Branch
star2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25310
Build 34940: Run Core Tests
Build 34939: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 17 2021, 8:45 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.