Page MenuHomePhabricator
Differential D21636

Default the Almanac Devices query to "Active Devices"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 10:50 PM.
Tags
None
Referenced Files
F14821150: D21636.id51491.diff
Tue, Jan 28, 5:49 AM
F14821148: D21636.id51484.diff
Tue, Jan 28, 5:49 AM
F14821146: D21636.id.diff
Tue, Jan 28, 5:49 AM
Unknown Object (File)
Sat, Jan 25, 4:49 PM
Unknown Object (File)
Fri, Jan 17, 6:34 PM
Unknown Object (File)
Mon, Jan 13, 5:42 PM
Unknown Object (File)
Fri, Jan 10, 11:16 PM
Unknown Object (File)
Mon, Dec 30, 1:01 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13641: Support "Disabled" devices in Almanac
Commits
rPe6a23274fee4: Default the Almanac Devices query to "Active Devices"
Summary

Ref T13641. Now that we can provide an "Active Devices" query, provide it and make it the default.

Test Plan

Viewed Almanac devices, got a list of active devices. Clicked "All Devices" to get all devices.

Diff Detail

Repository
rP Phabricator
Branch
almanac12
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25292
Build 34918: Run Core Tests
Build 34917: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 10:50 PM
Harbormaster completed remote builds in B25292: Diff 51484.Mar 16 2021, 10:51 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:51 PM
epriestley requested review of this revision.
Closed by commit rPe6a23274fee4: Default the Almanac Devices query to "Active Devices" (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPe6a23274fee4: Default the Almanac Devices query to "Active Devices".

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
query/
5 lines

Diff 51484

View Options

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

Loading...
Phabricator · Built by Phacility