Default the Almanac Devices query to "Active Devices"
ClosedPublic
Actions

Authored by epriestley on Mar 16 2021, 10:50 PM.

Tags

None

Referenced Files

	F13046118: D21636.id51484.diff
	Thu, Apr 18, 6:44 AM

	Unknown Object (File)
	Tue, Apr 9, 3:36 AM

	Unknown Object (File)
	Mon, Apr 8, 9:41 PM

	Unknown Object (File)
	Fri, Mar 29, 9:36 AM

	Unknown Object (File)
	Wed, Mar 27, 5:24 PM

	Unknown Object (File)
	Dec 27 2023, 1:48 PM

	Unknown Object (File)
	Dec 27 2023, 1:48 PM

	Unknown Object (File)
	Dec 27 2023, 1:48 PM

View All 58 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13641: Support "Disabled" devices in Almanac
Commits: rPe6a23274fee4: Default the Almanac Devices query to "Active Devices"

Summary

Ref T13641. Now that we can provide an "Active Devices" query, provide it and make it the default.

Test Plan

Viewed Almanac devices, got a list of active devices. Clicked "All Devices" to get all devices.

Diff Detail

Repository

rP Phabricator

Branch

almanac12

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25292
Build 34918: Run Core Tests
Build 34917: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 16 2021, 10:50 PM

Harbormaster completed remote builds in B25292: Diff 51484.Mar 16 2021, 10:51 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 10:51 PM

epriestley requested review of this revision.

Closed by commit rPe6a23274fee4: Default the Almanac Devices query to "Active Devices" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPe6a23274fee4: Default the Almanac Devices query to "Active Devices".

Revision Contents
Changeset List

Path

Size

src/

applications/

almanac/

query/

AlmanacDeviceSearchEngine.php

5 lines

Diff 51484

View Options

src/applications/almanac/query/AlmanacDeviceSearchEngine.php

Default the Almanac Devices query to "Active Devices"ClosedPublicActions