Page MenuHomePhabricator
Differential D21608

Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE permission
ClosedPublic
Actions

Authored by epriestley on Mar 11 2021, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 2:52 PM
Unknown Object (File)
Sat, Nov 23, 6:37 AM
Unknown Object (File)
Sat, Nov 23, 6:37 AM
Unknown Object (File)
Sat, Nov 23, 2:39 AM
Unknown Object (File)
Thu, Nov 21, 6:42 AM
Unknown Object (File)
Sun, Nov 17, 1:32 AM
Unknown Object (File)
Oct 23 2024, 9:13 PM
Unknown Object (File)
Oct 23 2024, 6:37 PM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13622: Make "bin/storage upgrade" deal with GRANT issues more gracefully
Commits
rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE…
Summary

Fixes T13622. Figuring out what permissions we have seems difficult, so address this a bit more narrowly:

  • Make the "access denied" error message a bit more helpful.
  • Tailor error handling for the "CREATE TEMPORARY TABLE" statement.
Test Plan
  • Created a new user, granted them "SELECT ON *.*" but not "CREATE TEMPORARY TABLE", ran bin/storage upgrade --force --apply phabricator:20210215.changeset.02.phid-populate.php.
  • Before: fairly opaque error.
  • After: fairly useful error.

Diff Detail

Repository
rP Phabricator
Branch
grant1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25246
Build 34844: Run Core Tests
Build 34843: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 11 2021, 10:32 PM
Owners added a subscriber: Restricted Owners Package.Mar 11 2021, 10:32 PM
Harbormaster completed remote builds in B25246: Diff 51439.Mar 11 2021, 10:33 PM
epriestley requested review of this revision.Mar 11 2021, 10:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2021, 10:55 PM
Closed by commit rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP32da29b96569: Provide more help around GRANT errors, particularly for missing TEMPORARY TABLE….

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
20 lines
src/
infrastructure/
storage/
connection/
mysql/
11 lines

Diff 51439

View Options

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

Loading...
View Options

src/infrastructure/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php

Loading...
Phabricator · Built by Phacility