Page MenuHomePhabricator

Modernize and clean up "PhabricatorAuditStatusConstants"
ClosedPublic

Authored by epriestley on Mar 10 2021, 5:15 PM.
Tags
None
Referenced Files
F13273719: D21599.diff
Fri, May 31, 2:30 AM
F13233878: D21599.diff
Tue, May 21, 2:38 AM
F13212156: D21599.diff
Fri, May 17, 6:25 AM
F13195737: D21599.diff
Sun, May 12, 10:35 PM
F13179694: D21599.diff
Wed, May 8, 9:22 PM
Unknown Object (File)
Mon, May 6, 3:57 AM
Unknown Object (File)
Sat, May 4, 6:58 PM
Unknown Object (File)
May 1 2024, 12:26 AM
Subscribers
None

Details

Summary

Ref T13631. Move "PhabricatorAuditStatusConstants" to a more modern object ("PhabricatorAuditRequestStatus").

Expose the status value via Conduit.

Test Plan
  • Ran bin/audit delete.
  • Viewed a commit with auditors in the web UI.
  • Grepped for affected symbols.
  • Called Conduit with the "auditors" attachment, saw auditor statuses.

Diff Detail

Repository
rP Phabricator
Branch
auditors3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25226
Build 34815: Run Core Tests
Build 34814: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.