Page MenuHomePhabricator

Modernize and clean up "PhabricatorAuditStatusConstants"
ClosedPublic

Authored by epriestley on Mar 10 2021, 5:15 PM.
Tags
None
Referenced Files
F15472264: D21599.id51420.diff
Sat, Apr 5, 12:14 PM
F15460419: D21599.id51420.diff
Mon, Mar 31, 10:53 PM
F15455486: D21599.id51419.diff
Sun, Mar 30, 12:45 AM
F15451538: D21599.id.diff
Fri, Mar 28, 10:36 PM
F15446983: D21599.diff
Thu, Mar 27, 9:14 PM
Unknown Object (File)
Feb 22 2025, 4:19 PM
Unknown Object (File)
Feb 19 2025, 11:39 PM
Unknown Object (File)
Feb 19 2025, 11:39 PM
Subscribers
None

Details

Summary

Ref T13631. Move "PhabricatorAuditStatusConstants" to a more modern object ("PhabricatorAuditRequestStatus").

Expose the status value via Conduit.

Test Plan
  • Ran bin/audit delete.
  • Viewed a commit with auditors in the web UI.
  • Grepped for affected symbols.
  • Called Conduit with the "auditors" attachment, saw auditor statuses.

Diff Detail

Repository
rP Phabricator
Branch
auditors3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25226
Build 34815: Run Core Tests
Build 34814: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.