Page MenuHomePhabricator

Modernize and clean up "PhabricatorAuditStatusConstants"
ClosedPublic

Authored by epriestley on Mar 10 2021, 5:15 PM.
Tags
None
Referenced Files
F14732434: D21599.diff
Sat, Jan 18, 4:43 PM
F14730320: D21599.diff
Sat, Jan 18, 7:27 AM
Unknown Object (File)
Sun, Jan 12, 2:29 PM
Unknown Object (File)
Mon, Jan 6, 11:43 AM
Unknown Object (File)
Thu, Jan 2, 7:27 PM
Unknown Object (File)
Mon, Dec 23, 10:45 PM
Unknown Object (File)
Mon, Dec 23, 10:45 PM
Unknown Object (File)
Dec 6 2024, 9:41 AM
Subscribers
None

Details

Summary

Ref T13631. Move "PhabricatorAuditStatusConstants" to a more modern object ("PhabricatorAuditRequestStatus").

Expose the status value via Conduit.

Test Plan
  • Ran bin/audit delete.
  • Viewed a commit with auditors in the web UI.
  • Grepped for affected symbols.
  • Called Conduit with the "auditors" attachment, saw auditor statuses.

Diff Detail

Repository
rP Phabricator
Branch
auditors3
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25226
Build 34815: Run Core Tests
Build 34814: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 10 2021, 5:22 PM
This revision was automatically updated to reflect the committed changes.