Page MenuHomePhabricator

Provide default image alt text in more contexts and support custom alt text
ClosedPublic

Authored by epriestley on Mar 5 2021, 12:48 AM.
Tags
None
Referenced Files
F14601479: D21596.id51415.diff
Thu, Jan 9, 12:38 AM
Unknown Object (File)
Sun, Jan 5, 9:38 PM
Unknown Object (File)
Fri, Jan 3, 8:23 PM
Unknown Object (File)
Fri, Jan 3, 4:15 AM
Unknown Object (File)
Fri, Dec 27, 2:45 PM
Unknown Object (File)
Tue, Dec 24, 3:57 PM
Unknown Object (File)
Mon, Dec 23, 6:07 PM
Unknown Object (File)
Dec 8 2024, 6:17 PM
Subscribers
None

Details

Summary

Ref T13629.

  • Allow files to have custom alt text.
  • If a file doesn't have alt text, try to generate a plausible default alt text with the information we have.
Test Plan
  • Viewed image files in DocumentEngine diffs, files, {Fxxx} embeds, and lightboxes.
  • Saw default alt text in all cases, or custom alt text if provided.
  • Set, modified, and removed file alt text. Viewed timeline and feed.
  • Pulled alt text with "conduit.search".

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2021, 12:49 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.