Page MenuHomePhabricator

Provide default image alt text in more contexts and support custom alt text
ClosedPublic

Authored by epriestley on Mar 5 2021, 12:48 AM.
Tags
None
Referenced Files
F19800323: D21596.id51415.diff
Sat, Feb 28, 2:34 PM
F19785846: D21596.id51416.diff
Wed, Feb 25, 1:56 AM
F19674268: D21596.id51416.diff
Feb 8 2026, 7:17 AM
F19560083: D21596.id51416.diff
Jan 31 2026, 6:02 AM
F19303292: D21596.id51416.diff
Dec 23 2025, 10:39 PM
F19281339: D21596.id51415.diff
Dec 23 2025, 3:33 AM
F19058175: D21596.id51415.diff
Nov 29 2025, 1:10 AM
F19049907: D21596.diff
Nov 27 2025, 6:34 PM
Subscribers
None

Details

Summary

Ref T13629.

  • Allow files to have custom alt text.
  • If a file doesn't have alt text, try to generate a plausible default alt text with the information we have.
Test Plan
  • Viewed image files in DocumentEngine diffs, files, {Fxxx} embeds, and lightboxes.
  • Saw default alt text in all cases, or custom alt text if provided.
  • Set, modified, and removed file alt text. Viewed timeline and feed.
  • Pulled alt text with "conduit.search".

Diff Detail

Repository
rP Phabricator
Branch
alt1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25220
Build 34806: Run Core Tests
Build 34805: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2021, 12:49 AM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.