Hide the "Author" field in Differential on the web create workflow
ClosedPublic
Actions

Authored by epriestley on Mar 4 2021, 5:44 PM.

Details

Reviewers: None
Maniphest Tasks: T13628: Provide "Foist Upon", an inverse operation to "Commandeer"
Commits: rPfceb9a3f9e1d: Hide the "Author" field in Differential on the web create workflow

Summary

Ref T13628. When creating a revision, hide the recently introduced "Author" field.

It seems exceedingly unlikely that anyone would ever want to adjust this field when creating a revision, and this workflow already has a lot of fields and complexity, so this likely adds more noise than signal on the balance.

Test Plan

Created revisions via copy/paste on the web workflow, no longer saw "Author".
Used "Edit Revision" to adjust the author normally.

Diff Detail

Repository

rP Phabricator

Branch

foist3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25218
Build 34803: Run Core Tests
Build 34802: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 4 2021, 5:44 PM

Harbormaster completed remote builds in B25218: Diff 51413.Mar 4 2021, 5:45 PM

epriestley requested review of this revision.Mar 4 2021, 5:45 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2021, 11:50 PM

Closed by commit rPfceb9a3f9e1d: Hide the "Author" field in Differential on the web create workflow (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPfceb9a3f9e1d: Hide the "Author" field in Differential on the web create workflow.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

editor/

DifferentialRevisionEditEngine.php

9 lines

Diff 51413

View Options

src/applications/differential/editor/DifferentialRevisionEditEngine.php

Hide the "Author" field in Differential on the web create workflowClosedPublicActions