Add more useful PHIDs to Harbormaster build variables
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 9:35 PM.

Tags

None

Referenced Files

	F15336788: D21569.diff
	Sun, Mar 9, 1:36 AM

	F15331499: D21569.diff
	Fri, Mar 7, 10:40 AM

	Unknown Object (File)
	Sun, Feb 23, 11:59 AM

	Unknown Object (File)
	Fri, Feb 21, 12:17 AM

	Unknown Object (File)
	Wed, Feb 19, 11:34 PM

	Unknown Object (File)
	Wed, Feb 19, 8:20 PM

	Unknown Object (File)
	Fri, Feb 14, 10:59 AM

	Unknown Object (File)
	Fri, Feb 14, 2:08 AM

View All Files

Subscribers

Restricted Owners Package

Details

Reviewers: None
Maniphest Tasks: T13609: Expose buildable object and container PHIDs as build variables
Commits: rP7c44657ca573: Add more useful PHIDs to Harbormaster build variables

Summary

Ref T13609. Add the Object PHID (object being built), Container PHID (container of the object being built), Build PHID, and Buildable PHID to Harbormaster build variables.

Test Plan

Screen Shot 2021-02-18 at 1.34.02 PM.png (633×904 px, 127 KB)

Screen Shot 2021-02-18 at 1.33.49 PM.png (364×585 px, 43 KB)

Diff Detail

Repository

rP Phabricator

Branch

bvar1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25150
Build 34712: Run Core Tests
Build 34711: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2021, 9:35 PM

Owners added a subscriber: Restricted Owners Package.Feb 18 2021, 9:35 PM

Harbormaster completed remote builds in B25150: Diff 51341.Feb 18 2021, 9:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 18 2021, 9:37 PM

epriestley requested review of this revision.

Closed by commit rP7c44657ca573: Add more useful PHIDs to Harbormaster build variables (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7c44657ca573: Add more useful PHIDs to Harbormaster build variables.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

storage/

build/

HarbormasterBuild.php

20 lines

Diff 51341

View Options

src/applications/harbormaster/storage/build/HarbormasterBuild.php

Add more useful PHIDs to Harbormaster build variablesClosedPublicActions