Page MenuHomePhabricator
Differential D21565

Provide a more structured result log for Herald rules
ClosedPublic
Actions

Authored by epriestley on Feb 18 2021, 6:53 PM.
Tags
None
Referenced Files
F15285696: D21565.diff
Tue, Mar 4, 3:32 PM
Unknown Object (File)
Wed, Feb 19, 8:25 PM
Unknown Object (File)
Wed, Feb 19, 5:44 PM
Unknown Object (File)
Wed, Feb 19, 5:44 PM
Unknown Object (File)
Tue, Feb 18, 4:42 AM
Unknown Object (File)
Feb 17 2025, 3:44 PM
Unknown Object (File)
Feb 16 2025, 10:26 PM
Unknown Object (File)
Feb 13 2025, 3:57 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13586: In Herald transcripts, surface exceptions encountered while evaluating fields
Commits
rP5bfd6bda7733: Provide a more structured result log for Herald rules
Summary

Ref T13586. In the footsteps of D21563, make Herald rule results more formal and structured to support meaningful exception reporting.

Test Plan

Ran various Herald rules and viewed transcripts, including rules with recursive dependencies and condition exceptions.

Screen Shot 2021-02-18 at 10.51.49 AM.png (354×1 px, 61 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25145
Build 34703: Run Core Tests
Build 34702: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 18 2021, 6:53 PM
Harbormaster completed remote builds in B25145: Diff 51336.Feb 18 2021, 6:54 PM
epriestley requested review of this revision.Feb 18 2021, 6:54 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 7:16 PM
Closed by commit rP5bfd6bda7733: Provide a more structured result log for Herald rules (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP5bfd6bda7733: Provide a more structured result log for Herald rules.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
48 lines
engine/
272 lines
exception/
3 lines
storage/
transcript/
11 lines
238 lines
69 lines
13 lines

Diff 51336

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/controller/HeraldTranscriptController.php

Loading...
View Options

src/applications/herald/engine/HeraldEngine.php

Loading...
View Options

src/applications/herald/engine/exception/HeraldRuleEvaluationException.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldConditionResult.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldRuleResult.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldRuleTranscript.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldTranscriptResult.php

Loading...
Phabricator · Built by Phacility