Page MenuHomePhabricator

Provide a more structured result log for Herald rules
ClosedPublic

Authored by epriestley on Feb 18 2021, 6:53 PM.
Tags
None
Referenced Files
F14861877: D21565.diff
Fri, Feb 7, 11:42 AM
Unknown Object (File)
Thu, Jan 30, 10:28 PM
Unknown Object (File)
Sat, Jan 25, 9:06 AM
Unknown Object (File)
Sat, Jan 25, 9:06 AM
Unknown Object (File)
Sat, Jan 25, 9:06 AM
Unknown Object (File)
Tue, Jan 21, 10:32 AM
Unknown Object (File)
Mon, Jan 13, 1:39 AM
Unknown Object (File)
Dec 30 2024, 6:05 AM
Subscribers
None

Details

Summary

Ref T13586. In the footsteps of D21563, make Herald rule results more formal and structured to support meaningful exception reporting.

Test Plan

Ran various Herald rules and viewed transcripts, including rules with recursive dependencies and condition exceptions.

Screen Shot 2021-02-18 at 10.51.49 AM.png (354×1 px, 61 KB)

Diff Detail

Repository
rP Phabricator
Branch
herald4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25145
Build 34703: Run Core Tests
Build 34702: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2021, 7:16 PM
This revision was automatically updated to reflect the committed changes.