Page MenuHomePhabricator
Differential D21557

Add a PHID to Changesets
ClosedPublic
Actions

Authored by epriestley on Feb 15 2021, 6:13 PM.
Tags
None
Referenced Files
F18056331: D21557.diff
Mon, Aug 4, 8:15 AM
F17943994: D21557.id51320.diff
Thu, Jul 31, 9:09 AM
F17943993: D21557.id51317.diff
Thu, Jul 31, 9:09 AM
F17943678: D21557.id.diff
Thu, Jul 31, 8:37 AM
F17845390: D21557.id51320.diff
Sun, Jul 27, 3:24 AM
F17833499: D21557.diff
Sat, Jul 26, 1:37 PM
Unknown Object (File)
Jul 3 2025, 4:08 AM
Unknown Object (File)
May 28 2025, 9:38 AM
View All Files
Subscribers
Restricted Owners Package

Details

Reviewers
None
Maniphest Tasks
T13605: Implement a "differential.changeset.search" API method
Commits
rPec5476a01f5f: Add a PHID to Changesets
Summary

Ref T13605. Changesets currently have no PHID, which limits their ability to use standard API infrastructure.

Give them a PHID, since there's no reason they don't have one other than their age.

Test Plan
  • Ran migrations, saw PHIDs populated.
  • Created new changesets, saw PHIDs.

Diff Detail

Repository
rP Phabricator
Branch
api1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25127
Build 34673: Run Core Tests
Build 34672: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2021, 6:13 PM
Owners added a subscriber: Restricted Owners Package.Feb 15 2021, 6:13 PM
Harbormaster completed remote builds in B25127: Diff 51317.Feb 15 2021, 6:15 PM
epriestley requested review of this revision.Feb 15 2021, 6:15 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 15 2021, 7:11 PM
Closed by commit rPec5476a01f5f: Add a PHID to Changesets (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPec5476a01f5f: Add a PHID to Changesets.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines
26 lines
src/
applications/
differential/
phid/
41 lines
storage/
5 lines

Diff 51317

View Options

resources/sql/autopatches/20210215.changeset.01.phid.sql

Loading...
View Options

resources/sql/autopatches/20210215.changeset.02.phid-populate.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/differential/phid/DifferentialChangesetPHIDType.php

Loading...
View Options

src/applications/differential/storage/DifferentialChangeset.php

Loading...
Phabricator · Built by Phacility