Page MenuHomePhabricator

Propagate the "ContextObject" to Remarkup rendering in timelines
ClosedPublic

Authored by epriestley on Feb 5 2021, 4:15 PM.
Tags
None
Referenced Files
F15409479: D21548.id51311.diff
Wed, Mar 19, 4:34 AM
F15407196: D21548.id51291.diff
Tue, Mar 18, 4:16 PM
F15379940: D21548.id51311.diff
Fri, Mar 14, 12:27 AM
F15333042: D21548.diff
Fri, Mar 7, 11:20 PM
F15298126: D21548.diff
Wed, Mar 5, 1:03 PM
Unknown Object (File)
Sun, Feb 23, 8:22 AM
Unknown Object (File)
Sat, Feb 22, 2:39 AM
Unknown Object (File)
Sat, Feb 22, 12:06 AM
Subscribers
None

Details

Summary

Ref T13602. Currently, timeline comment rendering does not (by default) propagate the context object to the rendering layer.

This means that @mentions of users who can't see the object aren't rendered properly (currently: they show up as blue, but should show up as grey).

Pass the context down the stack and into the remarkup engine.

Test Plan

Screen Shot 2021-02-05 at 8.13.07 AM.png (144×233 px, 7 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
This revision was automatically updated to reflect the committed changes.