Propagate the "ContextObject" to Remarkup rendering in timelines
ClosedPublic
Actions

Authored by epriestley on Feb 5 2021, 4:15 PM.

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rP58bbd6ee8838: Propagate the "ContextObject" to Remarkup rendering in timelines

Summary

Ref T13602. Currently, timeline comment rendering does not (by default) propagate the context object to the rendering layer.

This means that @mentions of users who can't see the object aren't rendered properly (currently: they show up as blue, but should show up as grey).

Pass the context down the stack and into the remarkup engine.

Test Plan

Screen Shot 2021-02-05 at 8.13.07 AM.png (144×233 px, 7 KB)

Diff Detail

Repository

rP Phabricator

Branch

policy3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25102
Build 34639: Run Core Tests
Build 34638: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 5 2021, 4:15 PM

Harbormaster completed remote builds in B25102: Diff 51291.Feb 5 2021, 4:16 PM

epriestley requested review of this revision.Feb 5 2021, 4:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM

Closed by commit rP58bbd6ee8838: Propagate the "ContextObject" to Remarkup rendering in timelines (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP58bbd6ee8838: Propagate the "ContextObject" to Remarkup rendering in timelines.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

engine/

PhabricatorTimelineEngine.php

1 line

view/

PhabricatorApplicationTransactionView.php

17 lines

Diff 51291

View Options

src/applications/transactions/engine/PhabricatorTimelineEngine.php