Page MenuHomePhabricator
Differential D21555

When a reviewer can't see a revision, show it clearly in the reviewer list
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 9:12 PM.
Tags
None
Referenced Files
F15470684: D21555.id51313.diff
Sat, Apr 5, 12:28 AM
F15467501: D21555.diff
Thu, Apr 3, 3:40 PM
F15435898: D21555.diff
Tue, Mar 25, 10:48 AM
F15391026: D21555.id51307.diff
Sat, Mar 15, 7:53 AM
Unknown Object (File)
Feb 22 2025, 12:19 AM
Unknown Object (File)
Feb 20 2025, 2:44 AM
Unknown Object (File)
Feb 9 2025, 10:01 AM
Unknown Object (File)
Feb 9 2025, 10:01 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list
Summary

Ref T13602. Similar to subscriber and mention treatments, make it clear when a user doesn't have view permission.

Test Plan

Screen Shot 2021-02-13 at 1.10.59 PM.png (195×393 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
policy6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25116
Build 34660: Run Core Tests
Build 34659: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2021, 9:12 PM
Harbormaster completed remote builds in B25116: Diff 51307.Feb 13 2021, 9:13 PM
epriestley requested review of this revision.Feb 13 2021, 9:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:37 PM
Closed by commit rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP2f33dedc8b62: When a reviewer can't see a revision, show it clearly in the reviewer list.

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
differential/
view/
23 lines
phid/
14 lines
view/
phui/
10 lines
webroot/
rsrc/
css/
phui/
8 lines

Diff 51307

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/differential/view/DifferentialReviewersView.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/view/phui/PHUIStatusItemView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-status.css

Loading...
Phabricator · Built by Phacility