Page MenuHomePhabricator
Differential D21554

Render user hovercards with context information about their ability to see the context object
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 8:56 PM.
Tags
None
Referenced Files
F14076900: D21554.diff
Thu, Nov 21, 8:08 PM
Unknown Object (File)
Tue, Nov 19, 3:18 PM
Unknown Object (File)
Thu, Nov 14, 9:34 AM
Unknown Object (File)
Thu, Nov 14, 8:25 AM
Unknown Object (File)
Thu, Nov 14, 7:14 AM
Unknown Object (File)
Thu, Nov 14, 7:10 AM
Unknown Object (File)
Thu, Nov 14, 7:09 AM
Unknown Object (File)
Thu, Nov 14, 6:40 AM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits
rP90903282c706: Render user hovercards with context information about their ability to see the…
Summary

Ref T13602. When rendering a user hovercard, pass the object on which the reference appears. If the user can't see the object, make it clear on the hovecard.

Restyle the "nopermission" markup in mentions to make it more obvious what the style means: instead of grey text, use red with an explicit icon.

Test Plan

Screen Shot 2021-02-13 at 12.50.53 PM.png (467×564 px, 35 KB)

Diff Detail

Repository
rP Phabricator
Branch
policy5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25115
Build 34658: Run Core Tests
Build 34657: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 13 2021, 8:56 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 13 2021, 8:57 PM
Harbormaster failed remote builds in B25114: Diff 51305!
epriestley updated this revision to Diff 51306.Feb 13 2021, 9:10 PM
  • Update celerity map.
Harbormaster completed remote builds in B25115: Diff 51306.Feb 13 2021, 9:11 PM
epriestley requested review of this revision.Feb 13 2021, 9:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:38 PM
Closed by commit rP90903282c706: Render user hovercards with context information about their ability to see the… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP90903282c706: Render user hovercards with context information about their ability to see the….
0 mentioned this in T13662: Mentions break Phriction preview.Jul 22 2021, 4:20 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
src/
applications/
maniphest/
controller/
8 lines
people/
engineextension/
6 lines
markup/
8 lines
view/
32 lines
phid/
4 lines
search/
controller/
56 lines
infrastructure/
graph/
4 lines
view/
phui/
10 lines
35 lines
webroot/
rsrc/
css/
application/
project/
11 lines
core/
5 lines
phui/
12 lines
js/
core/
1 line
13 lines
2 lines

Diff 51306

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

src/applications/people/engineextension/PeopleHovercardEngineExtension.php

Loading...
View Options

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

Loading...
View Options

src/applications/people/view/PhabricatorUserCardView.php

Loading...
View Options

src/applications/phid/PhabricatorObjectHandle.php

Loading...
View Options

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...
View Options

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...
View Options

src/view/phui/PHUIHovercardView.php

Loading...
View Options

src/view/phui/PHUITagView.php

Loading...
View Options

webroot/rsrc/css/application/project/project-card-view.css

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/phui/phui-tag-view.css

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
View Options

webroot/rsrc/js/core/HovercardList.js

Loading...
View Options

webroot/rsrc/js/core/behavior-hovercard.js

Loading...
Phabricator · Built by Phacility