Differential D21554

Render user hovercards with context information about their ability to see the context object
ClosedPublic
Actions

Authored by epriestley on Feb 13 2021, 8:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 19, 3:18 PM

	Unknown Object (File)
	Thu, Nov 14, 9:34 AM

	Unknown Object (File)
	Thu, Nov 14, 8:25 AM

	Unknown Object (File)
	Thu, Nov 14, 7:14 AM

	Unknown Object (File)
	Thu, Nov 14, 7:10 AM

	Unknown Object (File)
	Thu, Nov 14, 7:09 AM

	Unknown Object (File)
	Thu, Nov 14, 6:40 AM

	Unknown Object (File)
	Thu, Nov 14, 6:04 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13602: Improve workflow when users who do not have permission to see a revision are added as reviewers
Commits: rP90903282c706: Render user hovercards with context information about their ability to see the…

Summary

Ref T13602. When rendering a user hovercard, pass the object on which the reference appears. If the user can't see the object, make it clear on the hovecard.

Restyle the "nopermission" markup in mentions to make it more obvious what the style means: instead of grey text, use red with an explicit icon.

Test Plan

Screen Shot 2021-02-13 at 12.50.53 PM.png (467×564 px, 35 KB)

Diff Detail

Repository

Branch

policy5

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 25114
Build 34656: Run Core Tests
Build 34655: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	117 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	203 ms	PhabricatorCelerityTestCase::testCelerityMaps Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
	0 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPHeaderParserTestCase::testHeaderParser 18 assertions passed.
		View Full Test Results (2 Failed · 435 Passed · 2 Skipped)

Event Timeline

epriestley created this revision.Feb 13 2021, 8:56 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 13 2021, 8:57 PM

Harbormaster failed remote builds in B25114: Diff 51305!

Update celerity map.

Harbormaster completed remote builds in B25115: Diff 51306.Feb 13 2021, 9:11 PM

epriestley requested review of this revision.Feb 13 2021, 9:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 13 2021, 9:38 PM

Closed by commit rP90903282c706: Render user hovercards with context information about their ability to see the… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP90903282c706: Render user hovercards with context information about their ability to see the….

0 mentioned this in T13662: Mentions break Phriction preview.Jul 22 2021, 4:20 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

8 lines

people/

engineextension/

PeopleHovercardEngineExtension.php

6 lines

markup/

PhabricatorMentionRemarkupRule.php

8 lines

view/

PhabricatorUserCardView.php

32 lines

phid/

PhabricatorObjectHandle.php

4 lines

search/

controller/

PhabricatorSearchHovercardController.php

56 lines

infrastructure/

graph/

ManiphestTaskGraph.php

4 lines

view/

phui/

PHUIHovercardView.php

10 lines

PHUITagView.php

35 lines

webroot/

rsrc/

css/

application/

project/

project-card-view.css

11 lines

core/

5 lines

phui/

phui-tag-view.css

12 lines

js/

core/

1 line

HovercardList.js

13 lines

behavior-hovercard.js

2 lines

Diff 51305

resources/celerity/map.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/people/engineextension/PeopleHovercardEngineExtension.php

Loading...

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

Loading...

src/applications/people/view/PhabricatorUserCardView.php

Loading...

src/applications/phid/PhabricatorObjectHandle.php

Loading...

src/applications/search/controller/PhabricatorSearchHovercardController.php

Loading...

src/infrastructure/graph/ManiphestTaskGraph.php

Loading...

src/view/phui/PHUIHovercardView.php

Loading...

src/view/phui/PHUITagView.php

Loading...

webroot/rsrc/css/application/project/project-card-view.css

Loading...

webroot/rsrc/css/core/remarkup.css

Loading...

webroot/rsrc/css/phui/phui-tag-view.css

Loading...

webroot/rsrc/js/core/Hovercard.js

Loading...

webroot/rsrc/js/core/HovercardList.js

Loading...

webroot/rsrc/js/core/behavior-hovercard.js

Loading...