Page MenuHomePhabricator

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list
ClosedPublic

Authored by epriestley on Feb 8 2021, 6:17 PM.
Tags
None
Referenced Files
F15526307: D21551.id.diff
Mon, Apr 21, 8:34 PM
F15490363: D21551.id51298.diff
Fri, Apr 11, 4:35 PM
F15490331: D21551.id51297.diff
Fri, Apr 11, 4:13 PM
F15488209: D21551.id.diff
Thu, Apr 10, 8:19 PM
F15482098: D21551.diff
Wed, Apr 9, 2:55 AM
F15475483: D21551.diff
Sun, Apr 6, 7:56 PM
F15470645: D21551.diff
Sat, Apr 5, 12:04 AM
F15464777: D21551.id51298.diff
Wed, Apr 2, 12:45 PM
Subscribers
None

Details

Summary

Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan

Diff Detail

Repository
rARC Arcanist
Branch
merge1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25108
Build 34648: Run Core Tests
Build 34647: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 6:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.