Page MenuHomePhabricator

In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list
ClosedPublic

Authored by epriestley on Feb 8 2021, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 3:22 AM
Unknown Object (File)
Tue, Apr 9, 12:37 AM
Unknown Object (File)
Sun, Apr 7, 4:38 AM
Unknown Object (File)
Thu, Apr 4, 9:43 PM
Unknown Object (File)
Wed, Apr 3, 5:42 AM
Unknown Object (File)
Mon, Apr 1, 12:22 PM
Unknown Object (File)
Sun, Mar 31, 7:25 AM
Unknown Object (File)
Sat, Mar 30, 9:52 AM
Subscribers
None

Details

Summary

Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan

Diff Detail

Repository
rARC Arcanist
Branch
merge1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25108
Build 34648: Run Core Tests
Build 34647: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 6:18 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.