In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a natrual list
ClosedPublic
Actions

Authored by epriestley on Feb 8 2021, 6:17 PM.

Details

Reviewers: None
Maniphest Tasks: T13588: PHP 8 Compatibility
Commits: rARC239ad5c55d8d: In "array_mergev()", guarantee the "call_user_func_array()" parameter list is a…

Summary

Ref T13588. The behavior of "call_user_func_array()" has changed in PHP8, and the function now attempts to use array keys as argument names.

This always fails when calling "array_merge()" (which does not accept named parameters), and may cause misbehavior in the general case.

Guarantee the argument is a natural list (with keys "0", "1", "2", ...).

Test Plan

Repository

rARC Arcanist

Branch

merge1

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Feb 8 2021, 6:18 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

utils/

9 lines