Paths

Table of Contentst

Differential D21528

Correct Diffusion browse behavior when visiting a path URI with no trailing slash
ClosedPublic
Actions

Authored by epriestley on Jan 28 2021, 12:34 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 23, 8:19 PM

	Unknown Object (File)
	Sat, Dec 14, 1:05 PM

	Unknown Object (File)
	Fri, Dec 13, 6:39 AM

	Unknown Object (File)
	Mon, Dec 9, 11:56 AM

	Unknown Object (File)
	Fri, Dec 6, 5:04 PM

	Unknown Object (File)
	Fri, Dec 6, 2:09 PM

	Unknown Object (File)
	Thu, Dec 5, 5:10 PM

	Unknown Object (File)
	Wed, Dec 4, 10:35 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13589: Git may interpret refnames as flags in some commands which accept both refs and paths
T13599: In Diffusion browse views, some trailing slash behavior could be improved
Commits: rPc339eb01d616: (stable) Correct Diffusion browse behavior when visiting a path URI with no…
rPd6fd36570407: Correct Diffusion browse behavior when visiting a path URI with no trailing…

Summary

See PHI1983. Ref T13599. Ref T13589. Currently, if you browse to a path browse URI in Diffusion without a trailing slash (/browse/master/src), you get a nonsensical view (the directory as a single item).

Be more precise in how "git ls-tree" arguments are constructed.

Test Plan

Visited files and directories in the browse view, with and without trailing slashes. Saw improved behavior for directories with no trailing slash and reasonable behavior in all other cases.

Diff Detail

Repository

Branch

path1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 25056
Build 34571: Run Core Tests
Build 34570: arc lint + arc unit

Event Timeline

epriestley created this revision.Jan 28 2021, 12:34 AM

Harbormaster completed remote builds in B25056: Diff 51243.Jan 28 2021, 12:35 AM

epriestley requested review of this revision.Jan 28 2021, 12:35 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2021, 4:53 PM

Closed by commit rPd6fd36570407: Correct Diffusion browse behavior when visiting a path URI with no trailing… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPd6fd36570407: Correct Diffusion browse behavior when visiting a path URI with no trailing….

epriestley added a commit: rPc339eb01d616: (stable) Correct Diffusion browse behavior when visiting a path URI with no….Jan 28 2021, 5:14 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionBrowseQueryConduitAPIMethod.php

13 lines

Diff 51243

src/applications/diffusion/conduit/DiffusionBrowseQueryConduitAPIMethod.php

Loading...