Page MenuHomePhabricator

Correct Diffusion browse behavior when visiting a path URI with no trailing slash
ClosedPublic

Authored by epriestley on Jan 28 2021, 12:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 4:09 AM
Unknown Object (File)
Thu, Mar 14, 5:50 PM
Unknown Object (File)
Feb 18 2024, 2:15 PM
Unknown Object (File)
Feb 16 2024, 3:19 PM
Unknown Object (File)
Feb 5 2024, 11:50 PM
Unknown Object (File)
Feb 4 2024, 12:38 AM
Unknown Object (File)
Jan 27 2024, 11:52 PM
Unknown Object (File)
Jan 25 2024, 2:30 AM
Subscribers
None

Details

Summary

See PHI1983. Ref T13599. Ref T13589. Currently, if you browse to a path browse URI in Diffusion without a trailing slash (/browse/master/src), you get a nonsensical view (the directory as a single item).

Be more precise in how "git ls-tree" arguments are constructed.

Test Plan

Visited files and directories in the browse view, with and without trailing slashes. Saw improved behavior for directories with no trailing slash and reasonable behavior in all other cases.

Diff Detail

Repository
rP Phabricator
Branch
path1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25056
Build 34571: Run Core Tests
Build 34570: arc lint + arc unit