Page MenuHomePhabricator

Correct Git repository browse behavior for differences in "ls-tree" output
ClosedPublic

Authored by epriestley on Jan 25 2021, 5:10 PM.
Tags
None
Referenced Files
F15377135: D21519.id51219.diff
Thu, Mar 13, 8:12 AM
F15367501: D21519.diff
Tue, Mar 11, 6:54 PM
F15306412: D21519.diff
Thu, Mar 6, 4:01 AM
F15283464: D21519.diff
Tue, Mar 4, 7:27 AM
Unknown Object (File)
Sat, Feb 22, 8:04 AM
Unknown Object (File)
Sat, Feb 22, 7:43 AM
Unknown Object (File)
Feb 6 2025, 6:34 PM
Unknown Object (File)
Feb 4 2025, 7:39 PM
Subscribers
None

Details

Summary

Ref T13589. The output for "git ls-tree commit:path" (the old invocation) and "git ls-tree commit -- path" (the new invocation) differs: the latter emits absolute paths.

Update the code to account for this difference in behavior.

Test Plan
  • Browsed a non-root directory in a Git repository in Diffusion.
  • Before: saw absolute paths.
  • After: saw relative paths.

Diff Detail

Repository
rP Phabricator
Branch
browse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25032
Build 34538: Run Core Tests
Build 34537: arc lint + arc unit