Page MenuHomePhabricator

Correct Git repository browse behavior for differences in "ls-tree" output
ClosedPublic

Authored by epriestley on Jan 25 2021, 5:10 PM.
Tags
None
Referenced Files
F18379526: D21519.id51219.diff
Thu, Aug 28, 4:06 PM
F18377847: D21519.diff
Thu, Aug 28, 1:34 PM
F18110071: D21519.id51219.diff
Mon, Aug 11, 3:58 PM
F18109010: D21519.id51220.diff
Mon, Aug 11, 11:11 AM
F18105244: D21519.id.diff
Sun, Aug 10, 5:06 PM
F18101858: D21519.diff
Sat, Aug 9, 4:11 PM
F18101325: D21519.id.diff
Sat, Aug 9, 12:27 PM
F17943500: D21519.diff
Thu, Jul 31, 8:24 AM
Subscribers
None

Details

Summary

Ref T13589. The output for "git ls-tree commit:path" (the old invocation) and "git ls-tree commit -- path" (the new invocation) differs: the latter emits absolute paths.

Update the code to account for this difference in behavior.

Test Plan
  • Browsed a non-root directory in a Git repository in Diffusion.
  • Before: saw absolute paths.
  • After: saw relative paths.

Diff Detail

Repository
rP Phabricator
Branch
browse1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 25032
Build 34538: Run Core Tests
Build 34537: arc lint + arc unit