Page MenuHomePhabricator

Never render "Show More Context" inside an inline comment suggestion diff
ClosedPublic

Authored by epriestley on Oct 2 2020, 4:44 PM.
Tags
None
Referenced Files
F15444889: D21476.id51118.diff
Thu, Mar 27, 11:43 AM
F15444642: D21476.id51119.diff
Thu, Mar 27, 10:30 AM
F15439694: D21476.id.diff
Wed, Mar 26, 8:56 AM
F15435386: D21476.diff
Tue, Mar 25, 8:01 AM
F15433997: D21476.id51118.diff
Tue, Mar 25, 1:29 AM
F15421309: D21476.diff
Fri, Mar 21, 10:31 PM
F15410081: D21476.diff
Wed, Mar 19, 6:45 AM
F15405142: D21476.diff
Tue, Mar 18, 10:25 AM
Subscribers
None

Details

Summary

See PHI1896. If you do this:

  • Create an inline comment over a wide range of lines.
  • Suggest an edit.
  • Make a change near the beginning of the block.
  • Make a change near the end of the block.
  • Save the inline.

...you get a rendering which includes a "Show More Context" fold in the middle.

Currently, this element renders in a visually broken way and consumes too many columns.

However, this element isn't ever desirable inside inline comment suggestions. Stop it from rendering entirely.

Test Plan
  • Made an inline comment suggestion across lines 1-50 with edits at the beginning and end, saw a contiguous diff.
  • Made smaller inline comment suggestions (one line, a few lines).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Oct 2 2020, 4:46 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.