Page MenuHomePhabricator

Fix "PhutilOpaqueEnvelopeTestCase" under PHP 7.4 with "zend.exception_ignore_args"
ClosedPublic

Authored by epriestley on Sep 30 2020, 2:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 11:11 AM
Unknown Object (File)
Feb 13 2024, 1:15 PM
Unknown Object (File)
Jan 5 2024, 4:42 PM
Unknown Object (File)
Dec 27 2023, 1:38 PM
Unknown Object (File)
Dec 27 2023, 1:38 PM
Unknown Object (File)
Dec 27 2023, 1:38 PM
Unknown Object (File)
Dec 27 2023, 1:38 PM
Unknown Object (File)
Dec 24 2023, 10:46 PM
Subscribers
None

Details

Summary

See PHI1894. PHP 7.4 introduced a new runtime configuration option, "zend.exception_ignore_args", which removes the "args" from exception backtraces.

The "PhutilOpaqueEnvelopeTestCase" relies on this behavior (since it explicitly inspects stack frames). Although the test isn't critical and could be restructured, it seems like there is little value to ever enabling this option in the context of Phabricator.

Disable it at startup so environments are more consistent across different PHP versions and configurations.

Test Plan
  • Enabled "zend.exception_ignore_args" under PHP 7.4.
  • Ran "PhutilOpaqueEnvelopeTestCase".
  • Before: failure, expected signpost value not present in stack trace (because no "args" are present on the exception).
  • After: test passes.

Diff Detail

Repository
rARC Arcanist
Branch
xdebug1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 24926
Build 34388: Run Core Tests
Build 34387: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 30 2020, 2:49 PM
epriestley requested review of this revision.
This revision was automatically updated to reflect the committed changes.