Update SES API to use AWSv4 signatures
ClosedPublic
Actions

Authored by epriestley on Sep 15 2020, 4:15 PM.

Details

Reviewers: None
Maniphest Tasks: T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly
T13570: Amazon is retiring SMTP V3 Signatures
Commits: rP3dfa89dd5d27: Update SES API to use AWSv4 signatures

Summary

Ref T13570. Fixes T13235. In most cases, we use modern (v4) signatures for almost all AWS API calls, and have for several years.

However, sending email via SES currently uses an older piece of external code which uses the older (v3) signature method.

AWS is retiring v3 signatures on October 1 2020, so this pathway will stop working.

Update the pathway to use PhutilAWSFuture, which provides v4 signatures.

T13235 discusses poor error messages from SES. Switching to Futures fixes this for free, as they have more useful error handling.

Test Plan

Configured an SES mailer, including the new region parameter.
Used bin/mail send-test to send mail via SES.
Sent invalid mail (from an unverified address); got a more useful error message.
Grepped for removed external, no hits.

Repository

rP Phabricator

Branch

ses1

Lint

Lint Passed

Unit

Test Failures

Build Status

	Time	Test
	0 ms	PhabricatorMailAdapterTestCase::testSupportsMessageID EXCEPTION (PhutilTypeCheckException): Parameter 'region' has invalid type. Expected type 'string', got type 'null'. #0 /Users/epriestley/dev/core/lib/arcanist/src/parser/PhutilTypeSpec.php(169): PhutilTypeSpec->check(NULL, 'region') #1 /Users/epriestley/dev/core/lib/phabricator/src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php(18): PhutilTypeSpec::checkMap(Array, Array)
	1 ms	PhabricatorMailAdapterTestCase::testSupportsMessageID EXCEPTION (PhutilTypeCheckException): Parameter 'region' has invalid type. Expected type 'string', got type 'null'. #0 /core/data/drydock/workingcopy-74/repo/arcanist/src/parser/PhutilTypeSpec.php(169): PhutilTypeSpec->check(NULL, 'region') #1 /core/data/drydock/workingcopy-74/repo/phabricator/src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php(22): PhutilTypeSpec::checkMap(Array, Array)
	0 ms	AlmanacNamesTestCase::testServiceOrDeviceNames 30 assertions passed.
	0 ms	AlmanacServiceTypeTestCase::testGetAllServiceTypes 1 assertion passed.
	0 ms	AphrontHTTPHeaderParserTestCase::testHeaderParser 18 assertions passed.
		View Full Test Results (2 Failed · 425 Passed · 2 Skipped)