Page MenuHomePhabricator
Differential D21461

Update SES API to use AWSv4 signatures
ClosedPublic
Actions

Authored by epriestley on Sep 15 2020, 4:15 PM.
Tags
None
Referenced Files
F14400431: D21461.diff
Sun, Dec 22, 7:41 PM
Unknown Object (File)
Fri, Dec 20, 8:53 PM
Unknown Object (File)
Tue, Dec 17, 9:24 PM
Unknown Object (File)
Mon, Dec 16, 4:15 AM
Unknown Object (File)
Thu, Dec 12, 11:15 PM
Unknown Object (File)
Fri, Dec 6, 6:59 AM
Unknown Object (File)
Thu, Dec 5, 4:41 AM
Unknown Object (File)
Wed, Dec 4, 2:39 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly
T13570: Amazon is retiring SMTP V3 Signatures
Commits
rP3dfa89dd5d27: Update SES API to use AWSv4 signatures
Summary

Ref T13570. Fixes T13235. In most cases, we use modern (v4) signatures for almost all AWS API calls, and have for several years.

However, sending email via SES currently uses an older piece of external code which uses the older (v3) signature method.

AWS is retiring v3 signatures on October 1 2020, so this pathway will stop working.

Update the pathway to use PhutilAWSFuture, which provides v4 signatures.

T13235 discusses poor error messages from SES. Switching to Futures fixes this for free, as they have more useful error handling.

Test Plan
  • Configured an SES mailer, including the new region parameter.
  • Used bin/mail send-test to send mail via SES.
  • Sent invalid mail (from an unverified address); got a more useful error message.
  • Grepped for removed external, no hits.

Diff Detail

Repository
rP Phabricator
Branch
ses1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24887
Build 34338: Run Core Tests
Build 34337: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 15 2020, 4:15 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 15 2020, 4:17 PM
Harbormaster failed remote builds in B24886: Diff 51071!
epriestley updated this revision to Diff 51072.Sep 15 2020, 4:19 PM
  • Fix test failure.
epriestley mentioned this in T13235: Replace "SimpleEmailService" with a subclass of "PhutilAWSFuture" that surfaces errors more clearly.Sep 15 2020, 4:19 PM
Harbormaster completed remote builds in B24887: Diff 51072.Sep 15 2020, 4:20 PM
epriestley requested review of this revision.Sep 15 2020, 4:20 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 15 2020, 8:03 PM
Closed by commit rP3dfa89dd5d27: Update SES API to use AWSv4 signatures (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3dfa89dd5d27: Update SES API to use AWSv4 signatures.

Revision Contents
Changeset List

PathSize
externals/
amazon-ses/
src/
applications/
metamta/
adapter/
34 lines
__tests__/
1 line
future/
21 lines
docs/
user/
configuration/
4 lines

Diff 51072

View Options

externals/amazon-ses/ses.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/metamta/adapter/PhabricatorMailAmazonSESAdapter.php

Loading...
View Options

src/applications/metamta/adapter/__tests__/PhabricatorMailAdapterTestCase.php

Loading...
View Options

src/applications/metamta/future/PhabricatorAWSSESFuture.php

Loading...
View Options

src/docs/user/configuration/configuring_outbound_email.diviner

Loading...
Phabricator · Built by Phacility