Page MenuHomePhabricator

When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic

Authored by epriestley on Sep 8 2020, 8:15 PM.
Tags
None
Referenced Files
F19810649: D21459.diff
Tue, Mar 3, 8:46 PM
F19657317: D21459.id51089.diff
Feb 6 2026, 8:49 PM
F19636179: D21459.id51089.diff
Feb 5 2026, 12:28 PM
F19527123: D21459.diff
Jan 18 2026, 11:06 PM
F19515171: D21459.diff
Jan 14 2026, 8:47 AM
F19515160: D21459.diff
Jan 14 2026, 8:34 AM
F19505395: D21459.diff
Jan 9 2026, 11:23 AM
F19505354: D21459.diff
Jan 9 2026, 11:18 AM
Subscribers
None

Details

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

  • Before: fatals on each substep.
  • After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository
rP Phabricator
Branch
cref11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24884
Build 34332: Run Core Tests
Build 34331: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.