When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic
Actions

Authored by epriestley on Sep 8 2020, 8:15 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
T13569: When running worker tasks in-process, subtasks which fail incorrectly cause the parent tasks to fail
Commits: rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole…

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

Before: fatals on each substep.
After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository

rP Phabricator

Branch

cref11

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24884
Build 34332: Run Core Tests
Build 34331: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 8 2020, 8:15 PM

Harbormaster completed remote builds in B24884: Diff 51069.Sep 8 2020, 8:17 PM

epriestley requested review of this revision.Sep 8 2020, 8:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM

Closed by commit rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP737e7c85412c: When an in-process worker subtask fails permanently, don't fatal the whole….

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

daemon/

workers/

PhabricatorWorker.php

17 lines

Diff 51069

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

When an in-process worker subtask fails permanently, don't fatal the whole processClosedPublicActions