Page MenuHomePhabricator

When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic

Authored by epriestley on Sep 8 2020, 8:15 PM.
Tags
None
Referenced Files
F18765034: D21459.id51069.diff
Tue, Oct 7, 9:10 AM
F18734356: D21459.id.diff
Tue, Sep 30, 10:52 PM
F18682668: D21459.diff
Fri, Sep 26, 6:18 AM
F18658946: D21459.id51089.diff
Tue, Sep 23, 9:11 AM
F18600194: D21459.diff
Sep 13 2025, 9:11 AM
F18571279: D21459.id51089.diff
Sep 10 2025, 4:53 AM
F18571277: D21459.id51069.diff
Sep 10 2025, 4:53 AM
F18111079: D21459.id51089.diff
Aug 12 2025, 6:34 AM
Subscribers
None

Details

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

  • Before: fatals on each substep.
  • After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository
rP Phabricator
Branch
cref11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24884
Build 34332: Run Core Tests
Build 34331: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.