Page MenuHomePhabricator

When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic

Authored by epriestley on Sep 8 2020, 8:15 PM.
Tags
None
Referenced Files
F19083386: D21459.id51089.diff
Tue, Dec 2, 12:35 PM
F19075129: D21459.diff
Mon, Dec 1, 8:35 AM
F19075121: D21459.diff
Mon, Dec 1, 8:33 AM
F19075062: D21459.diff
Mon, Dec 1, 8:15 AM
F18993567: D21459.id51069.diff
Wed, Nov 19, 8:11 AM
F18958419: D21459.id51089.diff
Nov 13 2025, 4:35 AM
F18837356: D21459.diff
Oct 27 2025, 4:59 AM
F18810406: D21459.id51089.diff
Oct 19 2025, 9:23 PM
Subscribers
None

Details

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

  • Before: fatals on each substep.
  • After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository
rP Phabricator
Branch
cref11
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24884
Build 34332: Run Core Tests
Build 34331: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.