Page MenuHomePhabricator

When an in-process worker subtask fails permanently, don't fatal the whole process
ClosedPublic

Authored by epriestley on Sep 8 2020, 8:15 PM.

Details

Summary

Ref T13552. Fixes T13569. Currently, if a process uses in-process tasks (usually, a debugging/diagnostic workflow) and those tasks (or tasks those tasks queue) fail permanently, the exception escapes to top level and the process exits.

This isn't desirable; catch the exception and fail them locally instead.

Test Plan

With a failing Asana integration and misconfigured Webhook, ran bin/repository reparse --publish ....

  • Before: fatals on each substep.
  • After: warnings emitted for failed substep, but process completes.

Diff Detail

Repository
rP Phabricator
Branch
cref11
Lint
Lint OK
Unit
Unit Tests OK
Build Status
Buildable 24884
Build 34332: Run Core Tests
Build 34331: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:37 AM
This revision was automatically updated to reflect the committed changes.