Turn "bypassCache" into a no-op in "diffusion.querycommits"
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 7:11 PM.

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits"

Summary

Ref T13552. The internal caller for this now uses "internal.commit.search", which is always authority-reading. No legitimate external caller should rely on the behavior of "bypassCache"; no-op it to simplify behavior.

Test Plan

Called "diffusion.querycommits", saw the same data as before.

Diff Detail

Repository

rP Phabricator

Branch

cref6

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 24861
Build 34296: Run Core Tests
Build 34295: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 7:11 PM

Harbormaster completed remote builds in B24861: Diff 51046.Aug 12 2020, 7:12 PM

epriestley requested review of this revision.Aug 12 2020, 7:12 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM

Closed by commit rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits" (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rP7d6874d9f099: Turn "bypassCache" into a no-op in "diffusion.querycommits".

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

conduit/

DiffusionQueryCommitsConduitAPIMethod.php

35 lines

Diff 51046

View Options

src/applications/diffusion/conduit/DiffusionQueryCommitsConduitAPIMethod.php

Turn "bypassCache" into a no-op in "diffusion.querycommits"ClosedPublicActions