Page MenuHomePhabricator
Differential D21446

Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 7:08 PM.
Tags
None
Referenced Files
F13098355: D21446.diff
Fri, Apr 26, 5:57 AM
F13095285: D21446.id.diff
Thu, Apr 25, 8:08 AM
Unknown Object (File)
Wed, Apr 24, 2:31 AM
Unknown Object (File)
Fri, Mar 29, 1:29 AM
Unknown Object (File)
Feb 20 2024, 8:30 AM
Unknown Object (File)
Feb 19 2024, 7:18 AM
Unknown Object (File)
Feb 14 2024, 8:28 PM
Unknown Object (File)
Jan 5 2024, 8:57 PM
View All 42 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits
rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not…
Summary

Ref T13552. Swap the call we're using to build "CommitRef" objects here to the recently-introduced "internal.commit.search" method.

Test Plan

Used "bin/repository reparse --message ..." to reparse commits, added "var_dump()" to inspect results. Saw sensible CommitRef and CommitData objects get built.

Diff Detail

Repository
rP Phabricator
Branch
cref5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24860
Build 34294: Run Core Tests
Build 34293: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 7:08 PM
Harbormaster completed remote builds in B24860: Diff 51045.Aug 12 2020, 7:09 PM
epriestley requested review of this revision.Aug 12 2020, 7:09 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
Closed by commit rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rP3a80efa440f0: Build "DiffusionCommitRef" objects from "internal.commit.search", not….

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
12 lines
repository/
storage/
22 lines
44 lines
worker/
5 lines
commitmessageparser/
25 lines

Diff 51045

View Options

src/applications/diffusion/query/DiffusionQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/repository/worker/PhabricatorRepositoryCommitParserWorker.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility