Page MenuHomePhabricator

Build "DiffusionCommitRef" objects from "internal.commit.search", not "diffusion.querycommits", in the message parser worker
ClosedPublic

Authored by epriestley on Aug 12 2020, 7:08 PM.

Details

Summary

Ref T13552. Swap the call we're using to build "CommitRef" objects here to the recently-introduced "internal.commit.search" method.

Test Plan

Used "bin/repository reparse --message ..." to reparse commits, added "var_dump()" to inspect results. Saw sensible CommitRef and CommitData objects get built.

Diff Detail

Repository
rP Phabricator
Branch
cref5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 24860
Build 34294: Run Core Tests
Build 34293: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.