Differential D21442

Lift Diffusion Conduit call proxying to the root level of Conduit
ClosedPublic
Actions

Authored by epriestley on Aug 12 2020, 6:32 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 10:53 PM

	Unknown Object (File)
	Mon, Nov 18, 5:28 AM

	Unknown Object (File)
	Thu, Nov 14, 2:11 PM

	Unknown Object (File)
	Thu, Nov 14, 1:42 PM

	Unknown Object (File)
	Thu, Nov 14, 12:06 PM

	Unknown Object (File)
	Thu, Nov 14, 10:14 AM

	Unknown Object (File)
	Thu, Nov 14, 4:51 AM

	Unknown Object (File)
	Sun, Nov 10, 2:11 PM

View All 90 Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13552: "Close Revision" actions are executed by the Message worker, and do not execute if a previously discovered commit becomes reachable from a permanent branch
Commits: rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit

Summary

Ref T13552. Some Diffusion conduit calls may only be served by a node which hosts a working copy on disk, so they're proxied if received by a different node.

This capability is currently bound tightly to "DiffusionRequest", which is a bundle of context parameters used by some Diffusion calls. However, call proxying is not fundamentally a Diffusion behavior.

I want to perform proxying on a "*.search" call which does not use the "DiffusionRequest" parameter bundle. Lift proxying to the root level of Conduit.

Test Plan

Browsed diffusion in a clusterized repsository.

Diff Detail

Repository

Branch

cref2

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php:101	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 24856
Build 34287: Run Core Tests
Build 34286: arc lint + arc unit

Event Timeline

epriestley created this revision.Aug 12 2020, 6:32 PM

Harbormaster completed remote builds in B24856: Diff 51041.Aug 12 2020, 6:33 PM

epriestley requested review of this revision.Aug 12 2020, 6:33 PM

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM

Closed by commit rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPa745055813e4: Lift Diffusion Conduit call proxying to the root level of Conduit.

Revision Contents
Changeset List

Path

Size

src/

applications/

conduit/

method/

ConduitAPIMethod.php

12 lines

protocol/

ConduitAPIRequest.php

4 lines

diffusion/

conduit/

DiffusionQueryConduitAPIMethod.php

75 lines

repository/

storage/

PhabricatorRepository.php

17 lines

Diff 51041

src/applications/conduit/method/ConduitAPIMethod.php

Loading...

src/applications/conduit/protocol/ConduitAPIRequest.php

Loading...

src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php

Loading...

src/applications/repository/storage/PhabricatorRepository.php

Loading...