Page MenuHomePhabricator

Lift Diffusion Conduit call proxying to the root level of Conduit
ClosedPublic

Authored by epriestley on Aug 12 2020, 6:32 PM.
Tags
None
Referenced Files
F15404208: D21442.diff
Tue, Mar 18, 6:46 AM
F15402244: D21442.id51079.diff
Mon, Mar 17, 9:32 PM
F15387564: D21442.id51079.diff
Sat, Mar 15, 2:36 AM
F15386280: D21442.id.diff
Sat, Mar 15, 12:16 AM
F15385752: D21442.diff
Fri, Mar 14, 11:18 PM
F15285358: D21442.id51041.diff
Tue, Mar 4, 1:09 PM
Unknown Object (File)
Fri, Feb 21, 3:35 PM
Unknown Object (File)
Feb 20 2025, 4:10 PM
Subscribers
None

Details

Summary

Ref T13552. Some Diffusion conduit calls may only be served by a node which hosts a working copy on disk, so they're proxied if received by a different node.

This capability is currently bound tightly to "DiffusionRequest", which is a bundle of context parameters used by some Diffusion calls. However, call proxying is not fundamentally a Diffusion behavior.

I want to perform proxying on a "*.search" call which does not use the "DiffusionRequest" parameter bundle. Lift proxying to the root level of Conduit.

Test Plan

Browsed diffusion in a clusterized repsository.

Diff Detail

Repository
rP Phabricator
Branch
cref2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php:101XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 24856
Build 34287: Run Core Tests
Build 34286: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2020, 12:36 AM
This revision was automatically updated to reflect the committed changes.